Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method HTTPError.WithInternal #2340

merged 1 commit into from Nov 19, 2022


Copy link

@aldas aldas commented Nov 19, 2022

Add new method HTTPError.WithInternal to be able to create clone of HTTPError with given error set as internal

Currently HTTPError has method SetInternal but this mutates that same error which is problematic when we use those public errors we have ala echo.ErrUnauthorized etc. For these cases creating clone of that error instance is better.

Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 92.37% // Head: 92.38% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (be420bf) compared to base (fd2b102).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2340      +/-   ##
+ Coverage   92.37%   92.38%   +0.01%     
  Files          37       37              
  Lines        4448     4454       +6     
+ Hits         4109     4115       +6     
  Misses        247      247              
  Partials       92       92              
Impacted Files Coverage Δ
echo.go 95.24% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas aldas merged commit be23ab6 into labstack:master Nov 19, 2022
@aldas aldas mentioned this pull request Dec 27, 2022
@aldas aldas deleted the httperror_withinternal branch December 29, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant