Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relative path determination from proprietary to std #2345

merged 1 commit into from Nov 23, 2022


Copy link

@zeek0x zeek0x commented Nov 23, 2022

I don't have a windows development environment, so I can't confirm that this will work as before, but I don't think replacing it with std will cause any problems.

Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 92.38% // Head: 92.54% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (b760cd8) compared to base (3c4d3b3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
+ Coverage   92.38%   92.54%   +0.15%     
  Files          37       37              
  Lines        4454     4441      -13     
- Hits         4115     4110       -5     
+ Misses        247      241       -6     
+ Partials       92       90       -2     
Impacted Files Coverage Δ
echo_fs.go 92.50% <100.00%> (+7.55%) ⬆️
middleware/jwt.go 92.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

aldas commented Nov 23, 2022

On windows isAbs does more work (checks special names like 'COM1' CON etc) but in that sense it is more correct and as we this function is not called during request doing more work is ok.

@aldas aldas merged commit 36ff0b3 into labstack:master Nov 23, 2022
@zeek0x zeek0x deleted the refactor/relative-path-determination branch November 26, 2022 07:24
@aldas aldas mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants