Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pupil Invisible LSL Relay #9

Merged
merged 36 commits into from Nov 12, 2019

Conversation

@romanroibu
Copy link
Contributor

romanroibu commented Nov 8, 2019

No description provided.

romanroibu added 28 commits Nov 6, 2019
@cboulay

This comment has been minimized.

Copy link
Contributor

cboulay commented Nov 8, 2019

Hi @romanroibu , can you give a brief description of what's changing? There have been users in the past who were a bit blind-sided by the previous major change to the pupil LSL plugin dataformat; it would be good if we could provide an explanation. What's the Pupil Invisible Gaze Relay device monitor? What are the advantageous for this vs. the pupil_capture method? etc.

Thank you!

@papr

This comment has been minimized.

Copy link
Collaborator

papr commented Nov 8, 2019

This is an additional lsl app. The old one does not change. Only thing that should change is the instructions

Copy link
Collaborator

papr left a comment

@romanroibu Please add a top-level readme explaining the main difference between the two lsl relays and their intended usages (Pupil Core + Capture, Pupil Invisible + stand-alone). Also point to the respective readme files in the subfolders for more information.

setup.py Outdated Show resolved Hide resolved
@gmierz

This comment has been minimized.

Copy link
Contributor

gmierz commented Nov 10, 2019

I'm not a reviewer here, but I want to make a friendly request to add a relay version control number to this similar to what was done here: #7

Please, and thank you! :)

romanroibu added 3 commits Nov 11, 2019
@romanroibu romanroibu force-pushed the romanroibu:pupil-invisible-relay branch from dd1355a to 01ee88d Nov 11, 2019
@romanroibu romanroibu requested a review from papr Nov 11, 2019
Copy link
Collaborator

papr left a comment

I think it would be better to link to the product pages instead.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-Authored-By: Pablo Prietz <pablo@prietz.org>
@romanroibu romanroibu force-pushed the romanroibu:pupil-invisible-relay branch from ed67a3e to db356ca Nov 11, 2019
@romanroibu romanroibu requested review from papr and cboulay Nov 11, 2019
@papr
papr approved these changes Nov 11, 2019
@papr papr marked this pull request as ready for review Nov 11, 2019
@papr papr marked this pull request as ready for review Nov 11, 2019
@papr

This comment has been minimized.

Copy link
Collaborator

papr commented Nov 11, 2019

@cboulay please also have a look at the release notes draft

@papr papr merged commit b921ee2 into labstreaminglayer:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.