Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_part_2, wrong part called #2

Closed
wants to merge 2 commits into from

Conversation

@bennettscience
Copy link
Contributor

bennettscience commented Dec 2, 2019

The part 2 unit test called the part 1 answer, not part 2.

@lachlan-eagling

This comment has been minimized.

Copy link
Owner

lachlan-eagling commented Dec 2, 2019

Hi @bennettscience,

Thanks for the PR, can't believe I missed that.

Are you able to please update the template for the unit tests and re-generate the unit test files so the fix applies to all of them?

Also, I can see the commit for your solution to part 1 has ended up in this PR, will need to remove that to avoid merging your solution in here. Will just need to revert that commit in this branch.

Let me know if there are any questions.

@bennettscience

This comment has been minimized.

Copy link
Contributor Author

bennettscience commented Dec 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.