diff --git a/src/node/index.js b/src/node/index.js index 7c3ca6e59..3722da46b 100644 --- a/src/node/index.js +++ b/src/node/index.js @@ -951,7 +951,6 @@ Request.prototype._end = function() { let data = this._data; const { req } = this; const { method } = this; - const methodsWithBody = ['PUT', 'POST', 'PATCH']; this._setTimeouts(); @@ -971,11 +970,7 @@ Request.prototype._end = function() { } // content-length - if ( - methodsWithBody.includes(method) && - data && - !req.getHeader('Content-Length') - ) { + if (data && !req.getHeader('Content-Length')) { req.setHeader( 'Content-Length', Buffer.isBuffer(data) ? data.length : Buffer.byteLength(data) diff --git a/test/request.js b/test/request.js index 8c36a4167..9e5bc2f56 100644 --- a/test/request.js +++ b/test/request.js @@ -172,21 +172,6 @@ describe('request', function() { }); }); - it('GET should not send the content-length header', next => { - request - .get(`${uri}/content-length`) - .send({ foo: 'bar' }) - .then(res => { - try { - assert(!res.badRequest); - next(); - } catch (err) { - next(err); - } - }) - .catch(next); - }); - it('get()', next => { request.get(`${uri}/notfound`).end((err, res) => { try { diff --git a/test/support/server.js b/test/support/server.js index 0cc9af08a..b06b0c0a2 100644 --- a/test/support/server.js +++ b/test/support/server.js @@ -578,17 +578,5 @@ app.get('/error/redirect-error:id', (req, res) => { } }); -app.get('/content-length', (req, res) => { - const { headers } = req; - if ( - headers.hasOwnProperty('content-length') && - headers['content-length'] > 0 - ) { - res.status(400).send('bad request'); - } else { - res.status(200).send('ok'); - } -}); - const server = http.createServer(app); server.listen(process.env.ZUUL_PORT);