Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified three phase and finished 5 phase #157

Merged
merged 6 commits into from Jul 17, 2017

Conversation

Projects
None yet
1 participant
@mostaphaRoudsari
Copy link
Member

commented Jul 17, 2017

This PR adds 5-phase recipe and improves daylight coefficient and three phase recipes. I also used these classes to implement the workflow in grasshopper which will be pushed to honeybee-grasshopper. I will replicate a similar workflow to Dynamo this week.

Both daylight coefficient method and 5-phase method are using the improved direct contribution calculation using the SunMatrix class. The workflow is quite flexible and there is no limitation for the number of window groups or number of states for each window group. Once the results are loaded one can add / remove or change the state of each window group. Here is an example using daylight coefficient method:

normal windows

00

+ north facing window group

01

+ skylight

02

+ another skylight

03

+ the other skylight

04

= total

05

One can also iterate between the hours easily as the results are loaded into the grid. Here is the results for 3-phase method:

3phase_plan
3phase_perspective

and finally 5-phase:

5phase_plan
5phase_perspective

mostaphaRoudsari added some commits Jul 14, 2017

Moved dc methods to recipeutil
Separated commands for daylight coeff calculation as separate methods so
we can use the same functions for multi-phase recipes.
Also added some meaningful comments to batch file to make it human
readable . Resolved #149
Updated 3-phase method
tomorrow I will move the code from inside the recipe to recipeutil and
will mix them with daylight coefficient for 5phase recipe! It's pretty
doable now with what we have in place.

The recipes still need another round of work to connect each analysis
grid to certain window groups.
Finished adding the recipe for 5 phase
We finally support all the 3 major methods for advanced daylight
modeling. I tested the workflow in Grasshopper and python and both works
fine.

There are two changes that should be implented to this commit later.

1. recipeutil.py should be broken down into 3 or 4 files. base,
daylightcoeff, threephase and fivephase.

2. There is a duplication of code in the 5phase utilities. This can be
addressed by re-writing the threephase and daylight coeff functions.
This will also address the current problems inside batch files which
process and comments is not consistent.
Reviewed comments
This still needs more work but is good for now.

@mostaphaRoudsari mostaphaRoudsari merged commit 25f29e9 into master Jul 17, 2017

1 check passed

code-quality/landscape Code quality increased by 0.49%
Details

@mostaphaRoudsari mostaphaRoudsari deleted the threephase branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.