New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement shading algorithm based on external csv file. #211

Open
sariths opened this Issue Apr 4, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@sariths
Copy link
Member

sariths commented Apr 4, 2018

First pass discussions for what might eventually become a recipe

Based on this thread: http://discourse.ladybug.tools/t/dynamic-shading-controlled-by-csv-for-daylight-simulation-in-honeybee-legacy

@mostaphaRoudsari

This comment has been minimized.

Copy link
Member

mostaphaRoudsari commented Apr 4, 2018

I can be wrong but if I understand what is needed here which is calculating the results based on per-calculated blind combinations it's already implemented! Read csv as a text file, take the values and connect them to blindSates and there you have it!

@sariths

This comment has been minimized.

Copy link
Member

sariths commented Apr 4, 2018

@mostaphaRoudsari Totally forgot about all the coding gymnastics you did with the "states". Is this implemented for DC simulations too?
The existing functionality notwithstanding, I think addressing the controls aspect of it independently would be useful in the long run (hence the first line in my issue post.. "might eventually become a recipe".)

@mostaphaRoudsari

This comment has been minimized.

Copy link
Member

mostaphaRoudsari commented Apr 5, 2018

Is this implemented for DC simulations too?

It's implemented to AnalysisGrid and ImageCollection classes for post processing the results so it works for all the recipes including DC both grid-based and image-based!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment