New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop agents #19

Closed
laforge49 opened this Issue Oct 7, 2013 · 7 comments

Comments

Projects
None yet
2 participants
@laforge49
Copy link
Owner

laforge49 commented Oct 7, 2013

I realized this morning that there is nothing you can do with agents that can not be done more easily and efficiently with a request. Conclusion: I am still a novice when it comes to JActor2! :D

The only exception would be an agent that retains state between invocations. But that seems to be pretty rare. And more likely we would just use a blade that supports multiple requests anyway.

So we should drop agents. And replace PrinterAgent with an abstract class, SyncPrinterRequest.

@skunkiferous

This comment has been minimized.

Copy link
Collaborator

skunkiferous commented Oct 7, 2013

I thought the main use-case for Agents were sending an actor to a remote system; you cannot do that with a request, since it has direct references to source and/or target actors.

@ghost ghost assigned laforge49 Oct 7, 2013

@laforge49

This comment has been minimized.

Copy link
Owner

laforge49 commented Oct 7, 2013

Correct. So agents will likely resurface later. Agents as currently found in JActor2 are not serializable and so unsuitable for use with remote systems.

@laforge49

This comment has been minimized.

Copy link
Owner

laforge49 commented Oct 7, 2013

I expect to deprecate agents and add SyncPrintRequest in 0.3.5. And to drop agents in 0.3.6. I see no need to go to 0.4.0 when dropping agents as I doubt that anyone is using them.

@laforge49

This comment has been minimized.

Copy link
Owner

laforge49 commented Oct 7, 2013

deprecated agents: 23ae8ae

@laforge49

This comment has been minimized.

Copy link
Owner

laforge49 commented Oct 7, 2013

added SynkPrinterRequest: 9136a44

@laforge49

This comment has been minimized.

Copy link
Owner

laforge49 commented Oct 8, 2013

changes left out of 0.3.5: new sync and async requests fa6bbb7

@laforge49

This comment has been minimized.

Copy link
Owner

laforge49 commented Oct 9, 2013

agents have now been dropped from core: 3480c5b

@laforge49 laforge49 closed this Oct 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment