Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up window from panel indicator/icon too much to the left, not fully visible #13

Open
Filbuntu opened this issue May 11, 2018 · 8 comments

Comments

@Filbuntu
Copy link

Installation on Ubuntu 18.04 worked fine with pip3, but the displayed list (pop-up window) is placed too much to the left side and therefore not fully visible.
screenshot from 2018-05-07 20-59-47

How could I change this? Or how could the app be edited to fully show the window below the icon/indicator?

@lafrech
Copy link
Owner

lafrech commented May 15, 2018

Thanks for reporting.

I can't reproduce.

I don't run the same desktop environment. I use Mate. When I put the panel on the left, the window displays properly.

@lafrech
Copy link
Owner

lafrech commented May 15, 2018

I suspected this could be due to the panel being on the left but I realize from your screenshot that your QBirthday icon is up right, like on my config.

The code responsible for the placement of the window is here:

        # Window shall appear under system tray icon
        systray_icon_pos = self.status_icon.geometry().center()
        self.move(systray_icon_pos.x() - self.width() / 2,
                  systray_icon_pos.y())

I don't understand why it doesn't work for you.

This code is not so clever. It is fitted to my "panel up" use case but I don't think I even thought about the other positions. Anyway, when I put the panel on the left, the window sticks to the left so as to stay entirely visible.

@Filbuntu
Copy link
Author

Filbuntu commented May 16, 2018 via email

@lafrech
Copy link
Owner

lafrech commented May 16, 2018

Maybe you can try to reach attention on a Ubuntu forum if you want someone to help with this.

This might be a simple fix.

@Filbuntu
Copy link
Author

Filbuntu commented May 16, 2018 via email

@Filbuntu
Copy link
Author

Filbuntu commented Jun 30, 2018

In the meantime there is a also a launchpad bug report: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1777240
Workaround: Reduce the numbers of displayed birthdays in the preferences until the window is not anymore too tall for the screen and the window is fully visible (at least on my system).

@lafrech
Copy link
Owner

lafrech commented Jul 3, 2018

The fact the the window is not fully visible when it is too big (too many birthdays to display) is a limitation of the current code. I could add a QScrollArea to display a scroll bar when needed. It takes quite a lot to fill a screen with typical modern dimensions, but from your screenshot, it looks like you have a lot of fiends and relatives and you reached that limit.

The wrong position, seems to be a Qt issue that I should be dealing with in the code. It is still unclear to me. For the record, I asked about it on SO.

@lafrech
Copy link
Owner

lafrech commented Jul 3, 2018

I opened a separate issue for the vertical scroll bar: #15.

Let's discuss only the position issue in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants