New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forwarded headers in service gateway #143

Open
jroper opened this Issue Aug 15, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@jroper
Member

jroper commented Aug 15, 2016

We should add forwarded headers to the service gateway for people that want to query remote IP/protocol.

@lutzh

This comment has been minimized.

Contributor

lutzh commented Aug 22, 2016

Happy to take this one, feel free to assign to me.

(Note to myself: Also see https://groups.google.com/d/topic/lagom-framework/5cEVoMDzGuU/discussion)

@lutzh

This comment has been minimized.

Contributor

lutzh commented Aug 29, 2016

If nobody has any strong objections, I'll go with X-Forwarded-For and X-Forwarded-Proto, as they seem to be more widespread in the field (e.g. used by Amazon's ELB http://docs.aws.amazon.com/elasticloadbalancing/latest/classic/x-forwarded-headers.html)

If you prefer / need the apparently less common, but more "standard" implementation of "Forwarded" as described in https://tools.ietf.org/html/rfc7239, now is the time to speak up.

@guizmaii

This comment has been minimized.

Contributor

guizmaii commented Sep 21, 2016

Just for information. The Play support for these headers : https://www.playframework.com/documentation/2.5.x/HTTPServer#Forwarded-header-version

X-Forwarded-For and X-Forwarded-Proto seem to be de facto standards but are more limited than the RFC standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment