New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing akka-http property #1652

Closed
renatocaval opened this Issue Nov 20, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@renatocaval
Copy link
Member

renatocaval commented Nov 20, 2018

We got some users complaining that Lagom 1.4.9 can't be deployed in Kubernetes because of missing akka-http property (akka.http.routing.decode-max-size).

see https://discuss.lightbend.com/t/no-configuration-setting-found-for-key-decode-max-size/2738/4

It was reported to happen in Lagom 1.4.9, but it's very likely to be affecting 1.5.0-RC1 as well.

They got the following stack trace:

Oops, cannot start the server.
com.typesafe.config.ConfigException$Missing: No configuration setting found for key 'decode-max-size'
	at com.typesafe.config.impl.SimpleConfig.findKeyOrNull(SimpleConfig.java:156)
	at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:174)
	at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:188)
	at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:193)
	at com.typesafe.config.impl.SimpleConfig.getString(SimpleConfig.java:250)
	at akka.http.impl.util.EnhancedConfig$.getPossiblyInfiniteBytes$extension(EnhancedConfig.scala:45)
	at akka.http.impl.settings.RoutingSettingsImpl$.fromSubConfig(RoutingSettingsImpl.scala:34)
	at akka.http.impl.settings.RoutingSettingsImpl$.fromSubConfig(RoutingSettingsImpl.scala:26)
	at akka.http.impl.util.SettingsCompanion.apply(SettingsCompanion.scala:51)
	at akka.http.scaladsl.settings.RoutingSettings$.apply(RoutingSettings.scala:46)
	at akka.http.scaladsl.settings.RoutingSettings$.apply(RoutingSettings.scala:45)
	at akka.http.scaladsl.settings.SettingsCompanion.apply(SettingsCompanion.scala:19)
	at akka.http.scaladsl.settings.SettingsCompanion.apply$(SettingsCompanion.scala:19)
	at akka.http.scaladsl.settings.RoutingSettings$.apply(RoutingSettings.scala:45)
	at akka.http.scaladsl.settings.SettingsCompanion.default(SettingsCompanion.scala:20)
	at akka.http.scaladsl.settings.SettingsCompanion.default$(SettingsCompanion.scala:20)
	at akka.http.scaladsl.settings.RoutingSettings$.default(RoutingSettings.scala:45)
	at akka.management.AkkaManagement.start(AkkaManagement.scala:112)
	at com.lightbend.rp.akkamanagement.AkkaManagementAutostart.<init>(AkkaManagementAutostart.scala:28)

This is exception is coming from akka-management. Most probably from reactive-lib akka-http routes that are added for cluster formation and health checks.

The missing property is define on akka-http reference.conf, but for some reason this is not being read.

@renatocaval

This comment has been minimized.

Copy link
Member

renatocaval commented Nov 20, 2018

I'm adding to 1.5.0 milestone with backporting to 1.4.9.

@ignasi35

This comment has been minimized.

Copy link
Member

ignasi35 commented Nov 21, 2018

Update: The discussion moved forward down to a successful workaround.

eed3si9n added a commit to lightbend/reactive-lib that referenced this issue Jan 6, 2019

explicitly depend on Akka HTTP
Ref https://discuss.lightbend.com/t/no-configuration-setting-found-for-key-decode-max-size/2738
Fixes #103
Fixes lagom/lagom#1652

explicitly depend on Akka HTTP to bring in 10.1.5 to avoid No configuration setting found for key 'decode-max-size'.
@eed3si9n

This comment has been minimized.

Copy link

eed3si9n commented Jan 6, 2019

I am bumping Akka HTTP for reactive-lib - lightbend/reactive-lib#104

@TimMoore

This comment has been minimized.

Copy link
Member

TimMoore commented Jan 7, 2019

Did we confirm that this is actually a problem for Lagom 1.4.9? Lagom 1.4.x is still using Akka HTTP 10.0, so nothing should be referencing decode-max-size unless something else is bringing in Akka HTTP 10.1.

@TimMoore

This comment has been minimized.

Copy link
Member

TimMoore commented Jan 7, 2019

I see now:

the issue we have when mixing 10.0.13 with 10.1.5, can also happen when mixing 10.0.13 with 10.0.14 because decode-max-size was backported

akka/akka-http#2307 (comment)

So @renatocaval should the fix also be backported to Akka HTTP 10.0.x?

eed3si9n added a commit to lightbend/reactive-lib that referenced this issue Jan 7, 2019

Downgrade the Akka HTTP to 10.0.15
Ref #104, #103
Ref https://discuss.lightbend.com/t/no-configuration-setting-found-for-key-decode-max-size/2738
Ref lagom/lagom#1652

As per recommendation by Play/Lagom team, I am downgrading the Akka HTTP to 10.0.15, which aligns with Lagom 1.4.x, as opposed to 10.1.5 that's compatible with Lagom 1.5.x.
@renatocaval

This comment has been minimized.

Copy link
Member

renatocaval commented Jan 10, 2019

So @renatocaval should the fix also be backported to Akka HTTP 10.0.x?

I asked here. No so sure if really needed to backport since we have it already added by reactive-lib.

We may simply document it in Lagom for now, see #1708

@ignasi35

This comment has been minimized.

Copy link
Member

ignasi35 commented Jan 11, 2019

Using sbt-reactive-app 1.6.x+ solves this issue thanks to lightbend/reactive-lib#105.

@ignasi35 ignasi35 closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment