Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update akka-actor, ... to 2.6.8 #2946

Merged
merged 8 commits into from Aug 25, 2020

Conversation

scala-steward
Copy link
Contributor

Updates

from 2.6.5 to 2.6.7.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

@ignasi35 ignasi35 added this to the 1.6.4 milestone Jul 13, 2020
@ignasi35
Copy link
Contributor

ignasi35 commented Jul 13, 2020

Lagom releases considerations

This can be merged as soon as master is using Akka 2.6.5. This must be backported to 1.6.x but only after 1.6.3 has been released.

@ignasi35
Copy link
Contributor

SBR-related task list

Akka 2.6.6+ includes SBR. This should be considered when bumping the version:

  • review the namespace and values on cluster/core/src/main/resources/play/reference-overrides-conf
  • review behavior on JoinClusterImpl wrt self-join VS SBR
  • update documentation
    • cluster.md
    • multiple links and mentions to the commercial version

@ignasi35 ignasi35 changed the title Update akka-actor, ... to 2.6.7 Update akka-actor, ... to 2.6.8 Jul 17, 2020
@ignasi35
Copy link
Contributor

With 2.6.8 released, I'm bumping the version in this PR since it already has some improvements.

Copy link
Contributor

@ihostage ihostage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction of some links

docs/manual/common/concepts/ComponentTechnologies.md Outdated Show resolved Hide resolved
docs/manual/java/guide/cluster/Cluster.md Outdated Show resolved Hide resolved
docs/manual/scala/guide/cluster/Cluster.md Outdated Show resolved Hide resolved
Co-authored-by: Sergey Morgunov <hostage@me.com>
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ignasi35 ignasi35 dismissed ihostage’s stale review August 24, 2020 10:32

All changes suggested are merged. :-)

@ignasi35
Copy link
Contributor

Did a cleanup of the depdenencies whitelist in preparation for 1.6.4. There's a couple of non-compliances but since we'll need to do another cleanupo before the release we'll fix those then.

…kka-actor-2.6.7

# Conflicts:
#	project/Dependencies.scala
@ignasi35
Copy link
Contributor

Did a cleanup of the depdenencies whitelist in preparation for 1.6.4. There's a couple of non-compliances but since we'll need to do another cleanupo before the release we'll fix those then.

When merging from master and fixing some clonficts I took the last few missing non-compliances out of the way.

@ignasi35 ignasi35 merged commit f8e90d2 into lagom:master Aug 25, 2020
@ignasi35
Copy link
Contributor

@Mergifyio backport 1.6.x

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2020

Command backport 1.6.x: failure

No backport have been created

  • Backport to branch 1.6.x failed

Cherry-pick of b685671 has failed:

On branch mergify/bp/1.6.x/pr-2946
Your branch is ahead of 'origin/1.6.x' by 5 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit b685671a3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   project/Dependencies.scala

no changes added to commit (use "git add" and/or "git commit -a")

@ignasi35 ignasi35 removed this from the 1.6.4 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants