Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Code refactored with unnecessary if conditions #577

merged 1 commit into from Mar 8, 2017


None yet
3 participants
Copy link

commented Mar 6, 2017

  • Corrected minor spelling mistakes.
  • Removed unnecessary if conditions.

@ignasi35 ignasi35 requested a review from TimMoore Mar 7, 2017

Copy link

left a comment

Looks good to me. Thank you, @himani1!

@TimMoore TimMoore merged commit 1f65049 into lagom:master Mar 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
typesafe-cla-validator All users have signed the CLA

@himani1 himani1 deleted the himani1:refactor-code branch Mar 8, 2017

mdonkers added a commit to mdonkers/lagom that referenced this pull request Mar 12, 2017

mdonkers added a commit to mdonkers/lagom that referenced this pull request Mar 12, 2017

Merge remote-tracking branch 'upstream/master'
* upstream/master: (171 commits)
  Refactored dependencies into separate file (lagom#581)
  Corrected minor spelling mistakes and removed unnecessary if conditions. (lagom#577)
  Handle AbstractMethodError from older JDBC drivers (lagom#574)
  Fix current schema detection (lagom#570)
  Moves additionalConfiguration to last so it has precedence (lagom#573)
  Update version on master to 1.4.0-SNAPSHOT (lagom#567)
  Increase timeouts in CqrsIntegrationTest (lagom#560)
  Doc: Remove cassandra configuration (lagom#556)
  Update Akka to 2.4.17 (lagom#554)
  Adds docs on mixing in LagomKafkaComponents (and client) (lagom#549)
  Always set a circuit breaker in the Scala API (lagom#548)
  Resize screenshots and reword titles (lagom#551)
  Moved and updated topics on integrating with IDEs (lagom#516)
  Test assertions only realize eventually (lagom#542)
  order desc so the default is the current release (lagom#544)
  Increase the sbt heap in the docs subproject (lagom#540)
  Upgrade to sbt-conductr 2.3.0-RC1 (lagom#526)
  Split the logging examples into Java and Scala (lagom#531)
  [WIP] Enable JS inclusion on javadocs post JDK 1.8.0_121 (lagom#510)
  Macro client generation should not use primitive conversion (lagom#520)

@TimMoore TimMoore added this to the 1.4.0 milestone Apr 13, 2017

@ignasi35 ignasi35 modified the milestones: 1.4.0, 1.4.0-M1 Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.