Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VCR for external http requests #212

Closed
mfenner opened this issue Jan 1, 2015 · 1 comment
Closed

Use VCR for external http requests #212

mfenner opened this issue Jan 1, 2015 · 1 comment
Labels
feature

Comments

@mfenner
Copy link
Member

mfenner commented Jan 1, 2015

We are currently using webmock. One important limitation of webmock is that we don't see errors when the external API responses change.
@mfenner mfenner added the feature label Jan 1, 2015
mfenner pushed a commit that referenced this issue Jan 1, 2015
added vcd configuration. #212
5e01e99
mfenner pushed a commit that referenced this issue Jan 1, 2015
fixed counter model spec using vcr. #212
762f9ea
mfenner pushed a commit that referenced this issue Jan 1, 2015
fixed pmc model spec using vcd. #212
60deedd
mfenner pushed a commit that referenced this issue Jan 1, 2015
don't use vcd (yet) for sources that require an API key. #212
0b4ef3c
mfenner pushed a commit that referenced this issue Jan 1, 2015
use vcr with datacite source. #212
b17b8b0
mfenner pushed a commit that referenced this issue Jan 1, 2015
we need data cite fixtures for parse_data specs. #212
27f9aea
mfenner pushed a commit that referenced this issue Jan 1, 2015
make wordpress source work with vcr. #212
62898bf
mfenner pushed a commit that referenced this issue Jan 1, 2015
make citeulike spec work with vcr. #212
b26a5b4
mfenner pushed a commit that referenced this issue Jan 1, 2015
prepared article_coverage_curated spec for vcr. #212
952da9e
mfenner pushed a commit that referenced this issue Jan 1, 2015
prepared article_coverage spec for vcr. #212
89df9e7
mfenner pushed a commit that referenced this issue Jan 1, 2015
prepared wikipedia spec for vcr. #212
72376b9
mfenner pushed a commit that referenced this issue Jan 1, 2015
prepared figshare spec for vcr. #212
2760b14
mfenner pushed a commit that referenced this issue Jan 1, 2015
prepared europe pmc fulltext spec for vcr. #212
5c8d6e1
mfenner pushed a commit that referenced this issue Jan 1, 2015
prepared plos fulltext source for vcr. #212
4b87655
mfenner pushed a commit that referenced this issue Jan 1, 2015
modified pmc_europe spec for vcr. #212
91c37cd
mfenner pushed a commit that referenced this issue Jan 1, 2015
modified pmc_europe_data spec for vcr. #212
ef07fa0
mfenner pushed a commit that referenced this issue Jan 1, 2015
modified pub_med spec for vcr. #212
7e81f7a
mfenner pushed a commit that referenced this issue Jan 1, 2015
modified status spec for vcr. #212
e6888f0
mfenner pushed a commit that referenced this issue Jan 1, 2015
modified plos import for vcr. #212
056daa9
mfenner pushed a commit that referenced this issue Jan 1, 2015
make datacite_import spec work with vcr. #212
90ee65e
mfenner pushed a commit that referenced this issue Jan 1, 2015
modified dates in datacite import fixture. #212
44630d8
mfenner pushed a commit that referenced this issue Jan 1, 2015
modify crossref_import spec to use vcr. #212
6257869
@mfenner
Copy link
Member Author

mfenner commented Jan 2, 2015

Most external API calls now use VCR.

@mfenner mfenner closed this as completed Jan 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfenner