New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing rspec acceptance tests #380

Closed
mfenner opened this Issue Jul 13, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@mfenner
Member

mfenner commented Jul 13, 2015

bin/rspec spec/features has failing tests:

Finished in 1 minute 42.9 seconds (files took 1.9 seconds to load)
79 examples, 15 failures

Some failures are related to the Persona single sign-on. We can use CAS or ORCID for running the tests. The future of Persona is unclear, so we shouldn't spend too much time fixing tests related to Persona.

@mfenner mfenner added the bug label Jul 13, 2015

@mfenner

This comment has been minimized.

Show comment
Hide comment
@mfenner

mfenner Jul 14, 2015

Member

Related to this: #385 fix _travis.yml configuration.

Member

mfenner commented Jul 14, 2015

Related to this: #385 fix _travis.yml configuration.

@mfenner

This comment has been minimized.

Show comment
Hide comment
@mfenner

mfenner Jul 14, 2015

Member

Screenshots of failing acceptance tests (using capybara-screenshot gem) are in tmp/capybara.

Member

mfenner commented Jul 14, 2015

Screenshots of failing acceptance tests (using capybara-screenshot gem) are in tmp/capybara.

@zdennis

This comment has been minimized.

Show comment
Hide comment
@zdennis

zdennis Jul 15, 2015

Contributor

One of the issues seems to be that memcached is starting up but is not properly running on the TravisCI box.

Output of ps aux | grep memcache:

nobody    2258  0.0  0.0 333412  1492 ?        Sl   20:16   0:00 /usr/bin/memcached -v -m 48 -p 11211 -u nobody -l 0.0.0.0
travis   22467  0.0  0.0   4352   648 pts/0    S+   20:24   0:00 sh -c ps aux | grep memcache
travis   22469  0.0  0.0   9336   940 pts/0    S+   20:24   0:00 grep memcache

Output of lsof -i :11211

Yep empty.

If we start memcached without using the built-in TravisCI service then it seems to work fine.

Contributor

zdennis commented Jul 15, 2015

One of the issues seems to be that memcached is starting up but is not properly running on the TravisCI box.

Output of ps aux | grep memcache:

nobody    2258  0.0  0.0 333412  1492 ?        Sl   20:16   0:00 /usr/bin/memcached -v -m 48 -p 11211 -u nobody -l 0.0.0.0
travis   22467  0.0  0.0   4352   648 pts/0    S+   20:24   0:00 sh -c ps aux | grep memcache
travis   22469  0.0  0.0   9336   940 pts/0    S+   20:24   0:00 grep memcache

Output of lsof -i :11211

Yep empty.

If we start memcached without using the built-in TravisCI service then it seems to work fine.

@zdennis

This comment has been minimized.

Show comment
Hide comment
@zdennis

zdennis Jul 15, 2015

Contributor

works.tracked

@mfenner, in commit 8ac0cf9 you changed the default value for works.tracked from true to false. This is causing issues in spec/features/works_page_spec.rb because the works created aren't tracked and aren't showing up by default.

I'm not sure what the appropriate resolution is. Can you take a look?

Contributor

zdennis commented Jul 15, 2015

works.tracked

@mfenner, in commit 8ac0cf9 you changed the default value for works.tracked from true to false. This is causing issues in spec/features/works_page_spec.rb because the works created aren't tracked and aren't showing up by default.

I'm not sure what the appropriate resolution is. Can you take a look?

@mfenner

This comment has been minimized.

Show comment
Hide comment
@mfenner

mfenner Jul 16, 2015

Member

Thanks for catching this. The proper resolution would be a tracked checkbox, which exists in the edit page, but not the new page. This checkbox should then be checked in the test.

Member

mfenner commented Jul 16, 2015

Thanks for catching this. The proper resolution would be a tracked checkbox, which exists in the edit page, but not the new page. This checkbox should then be checked in the test.

@mfenner

This comment has been minimized.

Show comment
Hide comment
@mfenner

mfenner Jul 16, 2015

Member

I think I want to change the session_store back to cookie_store instead of ActionDispatch::Session::CacheStore. Memcached is required to properly run Lagotto, but these errors are a little obscure. A user of the lagotto application has in the past run into the same issue when memcached was not running in production and he was unable to login.

The alternative would be to show a proper error message, but I have no strong needs to use the Rails cache anyway.

Member

mfenner commented Jul 16, 2015

I think I want to change the session_store back to cookie_store instead of ActionDispatch::Session::CacheStore. Memcached is required to properly run Lagotto, but these errors are a little obscure. A user of the lagotto application has in the past run into the same issue when memcached was not running in production and he was unable to login.

The alternative would be to show a proper error message, but I have no strong needs to use the Rails cache anyway.

@mfenner

This comment has been minimized.

Show comment
Hide comment
@mfenner

mfenner Jul 16, 2015

Member

A properly running memcached is still required in Travis, e.g. to run the tests checking proper caching of the APO.

Member

mfenner commented Jul 16, 2015

A properly running memcached is still required in Travis, e.g. to run the tests checking proper caching of the APO.

mfenner referenced this issue Jul 17, 2015

Merge pull request #386 from articlemetrics/issues/380-failing-accept…
…ance-tests

Issues/380 failing acceptance tests

@mfenner mfenner closed this Jul 17, 2015

@mfenner mfenner added this to the Lagotto 4.3 milestone Jul 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment