My profile banner doesn't show up properly #278

Closed
DiMono opened this Issue Feb 26, 2013 · 3 comments

2 participants

@DiMono

If you look at the image directly, it looks like this:

https://www.lag.tv/uploads/user/banner/23/Profile_Background_1.jpg

Note the grey that dots the middle and left of it. Now, if you go to my profile at https://www.lag.tv/profiles/dimono you'll notice that all of that is solid black, despite correctly not being so in the image on the server. What's going on with that?

@DiMono

So I looked into it, and I know what's going on with it: profile_fade-[numbers].png is still being shown over top of it, rather than being beneath it or replaced by it. Swap the order of those two divs and you should be fine.

@andypike

We add the fade on top to make sure that we have contrast between the text and the image under it. We don't know if the image is dark or light so this is a safe way to make sure that the text is always readable.

This is by design.

@andypike andypike closed this Feb 27, 2013
@DiMono

Right... except my other suggestion would nullify that requirement by forcing the contrast on a smaller scale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment