Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all color spaces to RGB (fixed #7) #8

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

AnonymouX47
Copy link
Contributor

@AnonymouX47 AnonymouX47 commented Oct 4, 2021

See description of #7.
Closes #7

Images in other color spaces are now converted to RGB.
It's no longer optional since the ANSI color codes use RGB only.

@lainq
Copy link
Owner

lainq commented Oct 4, 2021

Thank you for the contribution :)

@lainq lainq merged commit a666e6e into lainq:main Oct 4, 2021
@AnonymouX47
Copy link
Contributor Author

AnonymouX47 commented Oct 4, 2021

Thank you for the contribution :)

👍🏾 ... I actually just noticed the NameError in the f-string expression (introduced in 2409ee1), I can fix it in the updates I'm currently working on, if you haven't by then.

@AnonymouX47 AnonymouX47 deleted the forced-rgb-conversion branch October 4, 2021 12:18
@lainq
Copy link
Owner

lainq commented Oct 4, 2021

Thank you. I have fixed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancies in image colour space interpretation.
2 participants