New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected text not highlighted when using one of the Quilter themes in Notes-up #43

Closed
LievenHanssen opened this Issue Jul 25, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@LievenHanssen

LievenHanssen commented Jul 25, 2017

I previously reported this issue with Notes-up, but the maintainer there said that I should report it with Quilter. This is what Philip Scott said:

This is a problem with Quilter, and the custom styles it's using. (The Quilter theme also doesn't work in Scratch-text editor for example)

Please report it there :) Thanks!

So this is the bug that I encountered: when using Notes-up in one of the Quilter themes, either Quilter or Quilter Dark, selected text won't be highlighted. In any of the other themes, this is not the case, selected text is highlight like it usually is.
In the program Quilter itself I can't seem to reproduce this bug. I've made a short video which you can watch to see how the different themes affect the highlighting of selected text in Notes-up.

@lainsce

This comment has been minimized.

Owner

lainsce commented Jul 25, 2017

Well, using themes from an app in others is not advised because of these bugs & styling issues.
So, I'm going to be friendly and just say that use the Quilter themes just on Quilter, and not on Notes-Up/Scratch/etc.

These themes were custom made just for my app, and shouldn't be used on other programs.
I'll be studying however, if I can do the same stuff as the themes without needing them in the future.

@lainsce lainsce closed this Jul 25, 2017

@Philip-Scott

This comment has been minimized.

Contributor

Philip-Scott commented Jul 25, 2017

If a theme is going to be added globally, then it should work globally 😉 I think the main problem is that you're overwriting some of your theme values here:
https://github.com/lainsce/quilter/blob/master/src/Widgets/SourceView.vala

@lainsce lainsce added the invalid label Jul 25, 2017

@lainsce

This comment has been minimized.

Owner

lainsce commented Jul 25, 2017

I'll check those up to be on my theme, and release a fix.

@lainsce lainsce removed the invalid label Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment