Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added bundle that supports all active languages #81

Merged
merged 1 commit into from Oct 21, 2016
Merged

added bundle that supports all active languages #81

merged 1 commit into from Oct 21, 2016

Conversation

MaksymSemenykhin
Copy link
Contributor

Added bundle that supports all active languages

His can be handy if site uses js compressor and one js file change only on deploy.
This mean that all js langs files should be available any time.

  • Added js var language with project lang.
  • Added the ability to have all languages in js languageItems var.
  • Added bundle that contains all active langs can be used for prod js compression.

@lajax
Copy link
Owner

lajax commented Oct 21, 2016

Thanks!

@lajax lajax merged commit 9947821 into lajax:master Oct 21, 2016
@rhertogh rhertogh mentioned this pull request Feb 7, 2017
Closed
moltam added a commit that referenced this pull request Apr 15, 2017
@moltam
Fix JS file generator saving files with wrong content
10291e6 
There was a bug in PR #81 that caused wrong JS language item generation.
The Generator generated JS files for all languages, but saved the
current language items in all of them.

Fixes #92
moltam added a commit that referenced this pull request Apr 29, 2017
@moltam
Remove all language bundle (merged in #81, fixes #92)
322267f 
PR #81 introduced BC breaking changes, detailed in #92. The PR changed
the structure of JS message files, as a consequence messages from 
the old files are not loaded and translated correctly.

Because of the reasons mentioned above the PR is reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaksymSemenykhin @lajax @moltam