Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test vectors comments from Peter #60

Closed
fpalombini opened this issue Jan 27, 2021 · 2 comments
Closed

Test vectors comments from Peter #60

fpalombini opened this issue Jan 27, 2021 · 2 comments

Comments

@fpalombini
Copy link
Collaborator

page 51 info for IV_2m, algorithm number 10;
It might be good to remind that the 10 comes from the cose algorithm number specified in item 0 of the suite.

page 52 at the end
K_2e = HKDF-Expand( PRK, info, length) should that not be: K_2e = HKDF-Expand( PRK_3e2m, info, length) .
If not, what should it be?

The number of bytes are sometimes a bit magical; In some cases it can be reminded that ECDH uses 32 bytes and the signature of the ed25519 is 32 bytes as well.

page 51: may be mention that for MAC_2, 8 bytes is length of TAG

page 52: cbor bytes of Signature_or_MAC_2 or h'Signature_or_MAC_2' instead of Signature_or_MAC_2.

page 58 line 6-7: ID_CRED_I, h'Signature_or_MAC_3'

page 59, line 1, HKDF-Expand(PRK_4x3m, info, L))

message_3 = ( h'13', h'CIPHERTEXT_3')

gselander added a commit that referenced this issue Feb 22, 2021
@gselander
Copy link
Collaborator

@petervanderstok I tried to address what remains of these comments. Let me know I missed something.

@gselander
Copy link
Collaborator

Closed as discussed during Hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants