Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Wrong encoding for files with extension ≠ .html (xml, json, txt…) #62

Closed
naholyr opened this Issue · 2 comments

1 participant

@naholyr

I was trying to generate a "/rss.xml" based on a content handler : articles are taken from the punch-blog-content-handler but given the extension is .xml and not .html, then cache store will write it using binary encoding.

That's not what I want because in case of text file it will break encoding (I end with my UTF8 strings getting written as latin-1).

I fixed it with a generator hook, but it should probably be a core options. We may let user provide a list of paths or extensions that should be written using utf8 encoding instead of binary. Or if this is possible (I'm not sure you can distinguish them, but who knows) never use binary for generated files (from content handler) versus physically copied files.

@naholyr

Note: here's the why
S lection_018

@naholyr

And here's the third-party fix: https://github.com/naholyr/punch-fix-utf8

@laktek laktek closed this in a14174b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.