New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugging support. Minor refactoring #127

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ndobryanskyy
Copy link
Contributor

ndobryanskyy commented Nov 8, 2018

Hi, @mhart please take a look at this!

This PR takes a required step towards the ability to debug .NET Core application issue;

It adds additional optional flag -d and a known environment variable _SHOULD_WAIT_FOR_DEBUGGER if any of these is set Lambda will halt the execution until the debugger is attached. Apart from that this PR formats code style for access modifiers.

We have an issue in this repo also. This PR, takes the most lightweight approach and does not touch the Dockerfiles at all.

@mikemorain

This comment has been minimized.

Copy link

mikemorain commented Nov 13, 2018

Looks like a solid start for the integration to me. Thank you for changing to a loop to wait, to smooth out that IDE experience for the developers.

More a question than anything: do we feel that the timeout interval should be configurable?

@ndobryanskyy

This comment has been minimized.

Copy link
Contributor

ndobryanskyy commented Nov 13, 2018

@mikemorain surely we can add this functionality, but I don't see any practical use case for that. What do you think?

@mhart mhart force-pushed the lambci:master branch 2 times, most recently from d8f1da7 to aaf07e6 Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment