fix(l2): add test chain with a non-empty block and bug fixes #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jrchatruc
approved these changes
Feb 24, 2025
JereSalo
pushed a commit
that referenced
this pull request
Feb 28, 2025
**Motivation** The current `l2-loadtest.rlp` had empty blocks. After replacing with a chain that contains a non-empty block, a bug was discovered when creating a `ExecutionDB` from a `Store`: we would try to filter out new accounts using revm's `AccountStatus` but for some reason every account has the same status (`Touched`), meaning that we were not filtering at all. The solution was to not filter and assume that the `Store` is correct based on the success of the pre-execution (so if an account is missing from the parent state, then that account was created in the block to prove). **Description** - replaces `l2-loadtest.rlp` file with one that contains a non empty block - fixes the bug described above
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
**Motivation** The current `l2-loadtest.rlp` had empty blocks. After replacing with a chain that contains a non-empty block, a bug was discovered when creating a `ExecutionDB` from a `Store`: we would try to filter out new accounts using revm's `AccountStatus` but for some reason every account has the same status (`Touched`), meaning that we were not filtering at all. The solution was to not filter and assume that the `Store` is correct based on the success of the pre-execution (so if an account is missing from the parent state, then that account was created in the block to prove). **Description** - replaces `l2-loadtest.rlp` file with one that contains a non empty block - fixes the bug described above
fkrause98
pushed a commit
that referenced
this pull request
Mar 5, 2025
**Motivation** The current `l2-loadtest.rlp` had empty blocks. After replacing with a chain that contains a non-empty block, a bug was discovered when creating a `ExecutionDB` from a `Store`: we would try to filter out new accounts using revm's `AccountStatus` but for some reason every account has the same status (`Touched`), meaning that we were not filtering at all. The solution was to not filter and assume that the `Store` is correct based on the success of the pre-execution (so if an account is missing from the parent state, then that account was created in the block to prove). **Description** - replaces `l2-loadtest.rlp` file with one that contains a non empty block - fixes the bug described above
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…lass#2068) **Motivation** The current `l2-loadtest.rlp` had empty blocks. After replacing with a chain that contains a non-empty block, a bug was discovered when creating a `ExecutionDB` from a `Store`: we would try to filter out new accounts using revm's `AccountStatus` but for some reason every account has the same status (`Touched`), meaning that we were not filtering at all. The solution was to not filter and assume that the `Store` is correct based on the success of the pre-execution (so if an account is missing from the parent state, then that account was created in the block to prove). **Description** - replaces `l2-loadtest.rlp` file with one that contains a non empty block - fixes the bug described above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
l2-loadtest.rlphad empty blocks. After replacing with a chain that contains a non-empty block, a bug was discovered when creating aExecutionDBfrom aStore: we would try to filter out new accounts using revm'sAccountStatusbut for some reason every account has the same status (Touched), meaning that we were not filtering at all.The solution was to not filter and assume that the
Storeis correct based on the success of the pre-execution (so if an account is missing from the parent state, then that account was created in the block to prove).Description
l2-loadtest.rlpfile with one that contains a non empty block