Skip to content

Fix #133: cannot set dynamic variables in --watch mode #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

frenchy64
Copy link
Contributor

Closes #133

Rebinding the current set of dynamic variables in the future allows dynamic variables to be rebound in tests.

@frenchy64 frenchy64 requested a review from plexus February 5, 2020 02:44
@frenchy64 frenchy64 force-pushed the issue-133-set-dynamic-vars-watch branch from 6ce5d19 to 695f653 Compare February 5, 2020 04:18
@frenchy64
Copy link
Contributor Author

Force-pushed a better impl.

@plexus plexus merged commit 3eb1aac into lambdaisland:master Feb 5, 2020
@plexus
Copy link
Member

plexus commented Feb 5, 2020

Thanks! I'm sure that test took a bit of time to figure out :) I'll release this in a bit. If you make more PRs in the future please remember to update the CHANGELOG as well.

@plexus
Copy link
Member

plexus commented Feb 5, 2020

Released as 0.0-590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set! dynamic vars in --watch mode
2 participants