New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildinfo since endpoint #54
Conversation
Implements a endpoint returning a list of buildinfo files since a given date given in Unix time. Example: GET /api/buildinfo/since/0 Signed-off-by: Morten Linderud <morten@linderud.pw>
|
Random thought, but it might be a good idea to:
That would allow me to start at a low number without overloading the database and then slowly walk through all pages until an empty list is returned, then poll every hour until new entries are returned. |
|
What is the use-case here? You want to know about new buildinfo files? If so, there are surely better ways of doing this than polling. |
|
This is needed for #48, which was filed for https://salsa.debian.org/reproducible-builds/debian-rebuilder-setup/tree/integrate-srebuild buildinfo.debian.net pushing the info to us, the rebuilder, would work as well but that would require coordination with you to run a rebuilder. Ideally, anybody who wants to run a rebuilder should be able to get that data without having to coordinate anything. Something like server-sent-events or websockets would technically avoid polling as well, but require more work from both sides. :) |
|
(As an aside, can I request |
|
(Dropped "first revision of" prefix) |
Adds a created-since field to the api response, filters by gte (so as to avoid microsecond time drift) and sorts the results.
|
@Foxboron please take a look at Foxboron#1 to address soem of the remaining issues... |
|
ping, Foxboron and kpcyrd would be very happy to get this merged :) |
|
Likewise, I could stop replaying information on buildinfo.nyu.wtf when
this happens.
Foxboron, kpcyrd, I can take a dive at these fixes tonight, would you
like to do it sooner?
Thanks,
-Santiago.
…On Thu, Dec 13, 2018 at 02:42:57AM -0800, Holger Levsen wrote:
ping, Foxboron and kpcyrd would be very happy to get this merged :)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#54 (comment)
|
Signed-off-by: Morten Linderud <morten@linderud.pw>
578abaa
to
9e8de99
Compare
|
@lamby I have squashed the code review commit |
Implements a endpoint returning a list of buildinfo files since a given
date given in Unix time.
Example: GET /api/buildinfo/since/0
Signed-off-by: Morten Linderud morten@linderud.pw