Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import for migration deconstruction #19

Merged
merged 2 commits into from Feb 26, 2020
Merged

Fix import for migration deconstruction #19

merged 2 commits into from Feb 26, 2020

Conversation

@danpalmer
Copy link

danpalmer commented Feb 26, 2020

This field moved its "canonical" location a long time ago (tests pass on supported versions of Django), and while the .fields location works, it results in unstable migrations when an EnumField is compared to previous migrations, for a compound field comprised of an EnumField and something else. A motivating use-case for this would be a MoneyField that combines a DecimalField and an EnumField.

This field moved its "canonical" location a long time ago (tests pass on supported versions of Django), and while the `.fields` location works, it results in unstable migrations when an EnumField is compared to previous migrations, for a compound field comprised of an EnumField and something else. A motivating use-case for this would be a `MoneyField` that combines a `DecimalField` and an `EnumField`.
@danpalmer danpalmer force-pushed the danpalmer:master branch from 7b33ce3 to 1d51d2a Feb 26, 2020
The context argument is not always present, but we don't need it so loosen the requirement
@lamby lamby merged commit 324c1a5 into lamby:master Feb 26, 2020
@lamby

This comment has been minimized.

Copy link
Owner

lamby commented Feb 26, 2020

thanks; merged and released as 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.