New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to JSON encode attachments when present. #6

Merged
merged 2 commits into from Sep 15, 2015

Conversation

Projects
None yet
2 participants
@avelis
Contributor

avelis commented Sep 15, 2015

Helps #4.

Given that an attachments value will contain a data structure other
than a string. It is necessary for the value to be JSON encoded in
order to be parsed correctly by Slack’s chat.postMessage API.

Ability to JSON encode attachments when present.
Given that an attachments value will contain a data structure other
than a string. It is necessary for the value to be JSON encoded in
order to be parsed correctly by Slack’s chat.postMessage API.
@@ -1,3 +1,4 @@
import json

This comment has been minimized.

@lamby

lamby Sep 15, 2015

Owner

please add an extra newline after this import so they are nicely grouped

@lamby

lamby Sep 15, 2015

Owner

please add an extra newline after this import so they are nicely grouped

Addition of new line to properly group imports in API module.
By request of @lamby, this new line will format and visibly group
imports at the top of this module by their overall functionality.

This is a common best practice and increases readability of imports
used.

lamby added a commit that referenced this pull request Sep 15, 2015

Merge pull request #6 from avelis/master
Ability to JSON encode attachments when present.

@lamby lamby merged commit bb8d85f into lamby:master Sep 15, 2015

@lamby

This comment has been minimized.

Show comment
Hide comment
@lamby

lamby Sep 15, 2015

Owner

Thanks :)

Owner

lamby commented Sep 15, 2015

Thanks :)

@avelis

This comment has been minimized.

Show comment
Hide comment
@avelis

avelis Sep 15, 2015

Contributor

@lamby You bet! Thanks for merging the PR!

Contributor

avelis commented Sep 15, 2015

@lamby You bet! Thanks for merging the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment