Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks support #89

Merged
merged 4 commits into from Jun 26, 2019

Conversation

Projects
None yet
2 participants
@chesstrian
Copy link
Contributor

commented Jun 21, 2019

@chesstrian

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Hi @lamby, it'd be great to have this feature in the next version, please let me know if this makes sense for you or something additional is required.

slack_message('app/template.slack', blocks=[{
    'type': 'divider'
}])
@lamby
Copy link
Owner

left a comment

Looks great, we'd need to see some additions to the documentation too before we could merge it. :)

@@ -132,6 +132,9 @@ def slack_message(template, context=None, attachments=None, fail_silently=None,

if 'attachments' in data:
data['attachments'] = json.dumps(data['attachments'])

if 'blocks' in kwargs:

This comment has been minimized.

Copy link
@lamby

lamby Jun 21, 2019

Owner

Not sure this is right; should one be adding something to PARAMS earlier in the method rather than a special-case here?

@lamby

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2019

@chesstrian Looks great. Can you just address these concerns and we can merge it ASAP.

@chesstrian

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

@lamby, changes done

@lamby
Copy link
Owner

left a comment

Thanks again...

Show resolved Hide resolved django_slack/api.py Outdated
Show resolved Hide resolved django_slack/api.py Outdated

@lamby lamby merged commit a0cc05b into lamby:master Jun 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lamby

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

Awesome, this has been released in 5.14.0. :)

@chesstrian

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Great, thanks a lot 🙂

@chesstrian chesstrian deleted the chesstrian:patch-1 branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.