Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined types as per laminas/laminas-coding-standard:2.3.x upgrades #106

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Jul 7, 2022

In #104 (duplicate), we improved the types of internal and
public API. These were mixed with coding style improvements.

The coding style improvements have been merged separately via #103,
so this patch only includes the type/docblock improvements, which should ease the potential evolution of the
API of this package.

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

@Ocramius Ocramius added this to the 2.13.0 milestone Jul 7, 2022
@Ocramius Ocramius self-assigned this Jul 7, 2022
@Ocramius Ocramius force-pushed the feature/laminas-coding-standard-2.3.x-type-refinements branch from 6b8f703 to 126124b Compare Jul 7, 2022
In laminas#104 (duplicate), we improved the types of internal and
public API. These were mixed with coding style improvements.

The coding style improvements have been merged separately via laminas#103,
so this patch only includes the type/docblock improvements, which should ease the potential evolution of the
API of this package.
@Ocramius Ocramius force-pushed the feature/laminas-coding-standard-2.3.x-type-refinements branch from 126124b to 2539f32 Compare Jul 7, 2022
@Ocramius
Copy link
Member Author

Ocramius commented Jul 7, 2022

@gsteel you may be interested in checking this one - it's very closely related to your #104 work, but with some type refinements

src/Request/ArraySerializer.php Show resolved Hide resolved
src/Response/ArraySerializer.php Show resolved Hide resolved
src/functions/parse_cookie_header.php Outdated Show resolved Hide resolved
@@ -8,9 +8,10 @@
use function Laminas\Diactoros\parseCookieHeader as laminas_parseCookieHeader;
Copy link
Member

@boesing boesing Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we just drop this as we already removed support for the old zendframework implementation by adding conflict to composer.json?

Copy link
Member Author

@Ocramius Ocramius Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do declare these symbols: we can drop them, but not in this patch 🤔

@Ocramius Ocramius force-pushed the feature/laminas-coding-standard-2.3.x-type-refinements branch from dfa990d to 7880719 Compare Jul 7, 2022
@Ocramius Ocramius requested a review from boesing Jul 7, 2022
gsteel
gsteel approved these changes Jul 7, 2022
@Ocramius
Copy link
Member Author

Ocramius commented Jul 7, 2022

🚢 then - will cut a release, hoping for quick feedback in case of breakages

@Ocramius Ocramius merged commit 34ba650 into laminas:2.13.x Jul 7, 2022
13 checks passed
@Ocramius Ocramius deleted the feature/laminas-coding-standard-2.3.x-type-refinements branch Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants