Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static return type in RequestTrait #113

Merged
merged 1 commit into from Jul 28, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 28, 2022

Q A
Documentation yes
QA yes

Description

Solves psalm issues here and for consumers where a call to ServerRequest::withWhatever() would be inferred as RequestInterface rather than ServerRequestInterface

Signed-off-by: George Steel <george@net-glue.co.uk>
Copy link
Member

@Ocramius Ocramius left a comment

LGTM 👍

@Ocramius Ocramius self-assigned this Jul 28, 2022
@Ocramius Ocramius merged commit 6cb35f6 into laminas:2.14.x Jul 28, 2022
13 checks passed
@gsteel gsteel deleted the psr-static-return branch Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants