Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚Remove server initialization from test_notebooks #83

Merged
merged 5 commits into from Jun 9, 2022
Merged

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Jun 9, 2022

This should fix all our problems with builds. Now if notebook_path sees that the environment variable "NBPRJ_TEST_NBPATH" exists, then it uses it as a notebook path.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

@github-actions github-actions bot temporarily deployed to pull request June 9, 2022 15:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 9, 2022 16:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 9, 2022 16:16 Inactive
@Koncopd Koncopd changed the title Rewrite test_notebooks completely 💚Remove server initialization from test_notebooks Jun 9, 2022
@Koncopd Koncopd merged commit ff0dbad into main Jun 9, 2022
@Koncopd Koncopd deleted the tests branch June 9, 2022 16:19
@falexwolf
Copy link
Member

It really seems robust. I really like it! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants