New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests converted to use Moo instead of Moose #5

Merged
merged 1 commit into from Dec 8, 2015

Conversation

Projects
None yet
2 participants
@openstrike
Contributor

openstrike commented Dec 3, 2015

Having been assigned MooseX-Log-Log4perl as part of the CPAN PR Challenge I saw that it had recently been changed to use Moo instead of (the recently-deprecated) Any::Moose. However, when I tried to build the version from the repo the tests would fail because they depended on Moose (which I didn't have installed) and which was not listed as a dependency in the dist.

So, I've simply gone through the tests and replaced the use of Moose with Moo instead and they seem to work for me. The only exception is the author test at t/99bench.t which narrowly failed a couple of subtests on the thresholds. I've nothing to compare this with so it is your call whether that's a significant problem or not - they may well pass on your test platform after all. Here are the failures I received:

#   Failed test 'Call rate of ->log must be above 94% (33325 / 34528 = 92.93 %) to Log4perl direct'
#   at t/99bench.t line 94.

#   Failed test 'Call rate of ->log must be above 95% (33325 / 34296 = 93.56 %) to Log4perl via method'
#   at t/99bench.t line 101.
# Looks like you failed 2 tests of 6.

I hope that these changes are useful, if rather trivial. If there's anything else in the dist which you think might benefit from some attention, please feel free to suggest.

lammel added a commit that referenced this pull request Dec 8, 2015

Merge pull request #5 from openstrike/mootests
Tests converted to use Moo instead of Moose

@lammel lammel merged commit decddb9 into lammel:master Dec 8, 2015

@lammel

This comment has been minimized.

Show comment
Hide comment
@lammel

lammel Dec 8, 2015

Owner

Thanks for the patch. It's applied. I'll lower the limits for the benchmark as Perl seems to get more inefficient these days with every release. Calling a method seems to have quite a bit of overhead.

Owner

lammel commented Dec 8, 2015

Thanks for the patch. It's applied. I'll lower the limits for the benchmark as Perl seems to get more inefficient these days with every release. Calling a method seems to have quite a bit of overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment