Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tests converted to use Moo instead of Moose #5
Having been assigned MooseX-Log-Log4perl as part of the CPAN PR Challenge I saw that it had recently been changed to use Moo instead of (the recently-deprecated) Any::Moose. However, when I tried to build the version from the repo the tests would fail because they depended on Moose (which I didn't have installed) and which was not listed as a dependency in the dist.
So, I've simply gone through the tests and replaced the use of Moose with Moo instead and they seem to work for me. The only exception is the author test at t/99bench.t which narrowly failed a couple of subtests on the thresholds. I've nothing to compare this with so it is your call whether that's a significant problem or not - they may well pass on your test platform after all. Here are the failures I received:
I hope that these changes are useful, if rather trivial. If there's anything else in the dist which you think might benefit from some attention, please feel free to suggest.