New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bundled moltemplate distribution with installation instructions only #1270

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@akohlmey
Copy link
Member

akohlmey commented Jan 3, 2019

Purpose

Replace the moltemplate distribution with a detailed README file describing how to obtain and install moltemplate either via pip install moltemplate or through downloading the (latest) archive manually and installing it through either pip locally or manually updating $PATH.

This should help people to get up-to-date versions and have more convenience when downloading and installing installing in one step via pip.

Author(s)

Axel Kohlmeyer (Temple U)

Backward Compatibility

N/A

@akohlmey akohlmey added the tools label Jan 3, 2019

@akohlmey akohlmey added this to the Stable Release Spring 2019 milestone Jan 3, 2019

@akohlmey akohlmey requested a review from jewettaij Jan 3, 2019

@akohlmey

This comment has been minimized.

Copy link
Member Author

akohlmey commented Jan 3, 2019

@jewettaij here is an example for how what we discussed could be implemented. Feel free to make suggestions for changes or let me know if you'd rather keep it the way it was (but then we should definitely update it ASAP).

@jewettaij
Copy link
Collaborator

jewettaij left a comment

I really appreciate the detailed comprehensive installation instructions and summary.
Thanks Axel for putting this together.
Andrew

@akohlmey akohlmey self-assigned this Jan 8, 2019

@akohlmey akohlmey requested a review from sjplimp Jan 8, 2019

@akohlmey akohlmey requested a review from stanmoore1 Jan 31, 2019

@stanmoore1
Copy link
Contributor

stanmoore1 left a comment

Looks OK to me.

@akohlmey akohlmey merged commit d6a918f into lammps:master Jan 31, 2019

11 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/new-cmake-serial-pr merge run ended
Details
lammps/pull-requests/kokkos_omp head run ended
Details
lammps/pull-requests/new-build-docs-pr merge run ended
Details
lammps/pull-requests/new-kokkos-omp-pr merge run ended
Details
lammps/pull-requests/new-openmpi-pr merge run ended
Details
lammps/pull-requests/new-serial-pr merge run ended
Details
lammps/pull-requests/new-shlib-pr merge run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details

@akohlmey akohlmey deleted the akohlmey:get-moltemplate-from-web branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment