Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: move lmpgitversion generation to build phase #1376

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
3 participants
@junghans
Copy link
Member

junghans commented Mar 23, 2019

Fixes the issue described here: #1357 (comment), where changes in git id aren't always picked up.

@junghans junghans requested a review from akohlmey Mar 23, 2019

@junghans junghans requested a review from rbberger as a code owner Mar 23, 2019

@junghans junghans added the cmake label Mar 23, 2019

@akohlmey akohlmey requested review from sjplimp and stanmoore1 Mar 25, 2019

@akohlmey akohlmey added this to the Stable Release Spring 2019 milestone Mar 25, 2019

@sjplimp
Copy link
Contributor

sjplimp left a comment

fine by me

@akohlmey akohlmey merged commit 34d1ed9 into lammps:master Mar 25, 2019

6 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details

@junghans junghans deleted the junghans:cmake_gitversion branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.