Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendezvous2 #1384

Merged
merged 17 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@akohlmey
Copy link
Member

akohlmey commented Mar 26, 2019

Summary

2nd attempt to submit rendezvous protocol changes.

Author(s)

Steve Plimpton (SNL)

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

yes

Implementation Notes

This is the second attempt to merge this feature. Details are at #1238

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system

sjplimp and others added some commits Nov 30, 2018

@sjplimp sjplimp assigned akohlmey and unassigned sjplimp Mar 26, 2019

@sjplimp

This comment has been minimized.

Copy link
Contributor

sjplimp commented Mar 26, 2019

@akohlmey you can redo the testing with these 2 changes

@akohlmey akohlmey marked this pull request as ready for review Mar 26, 2019

@akohlmey akohlmey requested a review from sjplimp as a code owner Mar 26, 2019

@akohlmey

This comment has been minimized.

Copy link
Member Author

akohlmey commented Mar 27, 2019

@sjplimp @stanmoore1 the failure on lammps/pull-requests/regression-pr is a false positive in the testing process, that i have not found out yet how to correct. when i run tests manually with this branch, they now all complete for a large variety of inputs from the examples folder. so this is good to go regardless.

@stanmoore1

This comment has been minimized.

Copy link
Contributor

stanmoore1 commented Mar 27, 2019

@akohlmey sometimes just have to rebless the gold standard for the tests when there are false positives. A change in the order of operations can cause exponentially diverging trajectories.

@akohlmey

This comment has been minimized.

Copy link
Member Author

akohlmey commented Mar 27, 2019

@akohlmey sometimes just have to rebless the gold standard for the tests when there are false positives. A change in the order of operations can cause exponential diverging trajectories.

problem is, i cannot figure out without richard's help where that data is held and how i perform this task. i've tried a bunch of things, but nothing had any consequences, so we'll have to accept this false positive for now, until richard has time to do it for us or instruct me how to do it.

@akohlmey akohlmey merged commit 28a6dcd into master Mar 27, 2019

8 of 9 checks passed

lammps/pull-requests/regression-pr head run started
Details
lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
lammps/pull-requests/testing-omp-pr head run ended Tests completed (174 passed, 0 failed, 0 skipped)
Details
lammps/pull-requests/testing-pr head run ended Tests completed (174 passed, 0 failed, 0 skipped)
Details
@stanmoore1

This comment has been minimized.

Copy link
Contributor

stanmoore1 commented Mar 27, 2019

In Jenkins I temporarily change the run command to:

python lammps-testing/lammps_testing/regression.py 8 'mpiexec -np 8 /home/jenkins/workspace/lammps/pull-requests/regression-pr/lammps/src/lmp_mpi -v CORES 8' lammps-testing/tests/examples -only micelle -auto-rebless True -min-same-rows 0

Or can delete the files log.15Mar19.linux.8.micelle-rigid and log.15Mar19.linux.8.micelle by using the rm command inside Jenkins. Not sure how to delete them outside of Jenkins though.

@akohlmey akohlmey deleted the rendezvous2 branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.