Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add fix electron/stopping to USER-MISC #1399
Implements inelastic energy loss for fast particles in solids, as commonly required for the simulation of collision cascades.
Implementation by T. Metspalu (Tartu University) and K. Avchaciov (Tartu
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
No breaking changes.
Simple cpp+header in USER-MISC.
Post Submission Checklist
Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply
compute ke/atom creates a buffer for all atoms, this is wasteful and thus should be avoided.
looking at your fix, it would be just as simple to directly add the corresponding code from compute ke/atom (which is done in many other places, where the per-atom kinetic energy is used), e.g.:
Those are created manually with pdflatex, pdftoppm, pnmcrop, pnmtopjpeg or an image editor like gimp.
as of very recent, it is now also possible to typeset with LaTeX inside the manual, by using MathJax. See for instance the documentation for the recently added pair style granular. https://lammps.sandia.gov/doc/pair_granular.html
Thanks for the review.
Regarding the use of
@rtoijala @sjplimp i am wondering if
more explicit like this is definitely better. i am looking at this purely from the point of a code maintainer of a software package, that would like to make it easy for people to spot those commands which may be relevant to them.
let's wait and see if @sjplimp has something to add. Changing the name of the fix style would require to change the name of the class and the files to be consistent (so it is easier for developers to find the files they are looking for