Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and bugfixes to GRANULAR package #1420

Merged
merged 16 commits into from Apr 29, 2019

Conversation

@dsbolin
Copy link
Collaborator

commented Apr 8, 2019

Summary

Added examples for new generalized granular pair styles, fixed some errors in doc pages, some bugs that could affect fix wall/gran and fix wall/gran/region.

Author(s)
Dan Bolintineanu, Sandia National Labs

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Yes

Backward Compatibility

N/A, includes examples for new granular pair styles

Implementation Notes

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • [x ] One or more example input decks are included

Dan S. Bolintineanu added some commits Apr 2, 2019

Dan S. Bolintineanu
Fixes several bugs in fix wall/gran, wall/gran/region:
1. Radius of curvature for curved regions was incorrectly used to compute wall-particle overlaps
2. Uninitialized values of rolling and twisting history could produce crashes in
cases that don't initialize these to 0 by default. These are now initialized to 0.
3. Fixed a bug with the use of 'NULL' for specification of the tangential stiffness for
wall/gran and wall/gran/region

@dsbolin dsbolin marked this pull request as ready for review Apr 14, 2019

Dan S. Bolintineanu added some commits Apr 15, 2019

Dan S. Bolintineanu
Added a 'mass_velocity' damping option to the new granular pair style…
…s and granular wall interaction.

This is to more closely match the old style pair gran/hooke/* damping behavior.
Updated doc page accordingly, as well as adding some examples on how to match old pair gran/* styles.
Dan S. Bolintineanu
Dan S. Bolintineanu
Fixes bug in calculation of relative tangential velocity for granular…
… wall particle interactions.

Thanks to Andrew Santos for providing a test case that reveals this.
Dan S. Bolintineanu
Fixes a bug in pair granular that caused JKR cutoffs to be set incorr…
…ectly when multiple types with multiple cohesion values are used
Dan S. Bolintineanu
One more bug in pair_granular.cpp, where JKR cutoff was incorrectly c…
…omputed. Thanks to Ishan Srivastava for finding this one

@akohlmey akohlmey self-assigned this Apr 29, 2019

@akohlmey akohlmey added this to the Stable Release Spring 2019 milestone Apr 29, 2019

akohlmey added some commits Apr 29, 2019

@akohlmey akohlmey changed the title Gran mods Updates and bugfixes to GRANULAR package Apr 29, 2019

@akohlmey akohlmey requested review from sjplimp, athomps and rbberger Apr 29, 2019

@sjplimp
Copy link
Contributor

left a comment

looks good

@akohlmey akohlmey merged commit 8d9697d into lammps:master Apr 29, 2019

6 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.