Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes and bugfixes #1465

Merged
merged 6 commits into from May 21, 2019

Conversation

@akohlmey
Copy link
Member

commented May 17, 2019

Summary

This pull request combines multiple minor changes that do not warrant individual pull requests

Related Issues

None

Author(s)

Axel Kohlmeyer (Temple U)

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

yes.

Implementation Notes

The following individual changes are included:

  • dead code removal to reduce compiler warnings
  • remove some leftover references to the deleted MEAM package
  • update list of example folders in manual and README
  • remove restriction of Sphinx to a pre-2.x version as sphinxcontrib-spelling and its dependencies have been updated for Sphinx 2.x
  • avoid segmentation fault on unexpected empty lines in Coeff sections. improve error message.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

akohlmey added some commits May 18, 2019

@akohlmey akohlmey marked this pull request as ready for review May 21, 2019

@akohlmey akohlmey requested review from rbberger and sjplimp as code owners May 21, 2019

@akohlmey akohlmey self-assigned this May 21, 2019

@akohlmey akohlmey requested review from athomps and stanmoore1 May 21, 2019

@akohlmey akohlmey merged commit cfad063 into lammps:master May 21, 2019

6 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details

@akohlmey akohlmey deleted the akohlmey:collected-minor-changes branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.