Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected small changes for stable release #1475

Merged
merged 6 commits into from May 31, 2019

Conversation

@akohlmey
Copy link
Member

commented May 24, 2019

Summary

This PR combines multiple small changes that do not warrant individual pull requests.

Author(s)

Axel Kohlmeyer (Temple U)

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

yes.

Implementation Notes

The following individual changes are included:

  • correct links in the package documentation
  • implement alternative to gettimeofday() for native windows compiles
  • add check that allows only %f, %g, or %e conversions in format strings for format style or immediate variables.

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

akohlmey added some commits May 30, 2019

@akohlmey akohlmey self-assigned this May 30, 2019

@akohlmey akohlmey marked this pull request as ready for review May 30, 2019

@akohlmey akohlmey requested a review from sjplimp as a code owner May 30, 2019

@akohlmey akohlmey requested review from athomps and stanmoore1 May 30, 2019

Show resolved Hide resolved src/lmpwindows.h Outdated
@sjplimp
Copy link
Contributor

left a comment

fine by me

@akohlmey akohlmey requested a review from stanmoore1 May 30, 2019

@akohlmey akohlmey merged commit d8a30a9 into lammps:master May 31, 2019

6 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details

@akohlmey akohlmey deleted the akohlmey:collected-small-changes branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.