Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Restart updates for fixes atom/swap, deposit, and gcmc #1484
This PR has some updates and improvements when restarting fixes
This adds a check to avoid unexpected behavior as reported on lammps-users
Axel Kohlmeyer (Temple U)
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Restart files for the fixes atom/swap, deposit, and gcmc will not be backward compatible due to storing additional information.
This uses the ubuf() union to correctly store 64-bit timestep numbers in double buffers of the restart file. It also stores the number of MC attempts and successes as reported by the corresponding compute_vector() method of the fix into the restart file (so they won't start from zero again).
Post Submission Checklist
On Fri, May 31, 2019 at 10:41 AM Steve Plimpton ***@***.***> wrote: ***@***.**** approved this pull request. good upgrades, need to flag in the release notes this (presumably) breaks backward compatibility with old restart files
yes, it breaks compatibility with old restarts. i checked.…
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1484?email_source=notifications&email_token=AACGTY2BVJN4LKJPDNVV74TPYE2KDA5CNFSM4HRSWINKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2IG6PI#pullrequestreview-244346685>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACGTYZSU3N6HQETZ4X2PJLPYE2KDANCNFSM4HRSWINA> .
-- Dr. Axel Kohlmeyer firstname.lastname@example.org http://goo.gl/1wk0 College of Science & Technology, Temple University, Philadelphia PA, USA International Centre for Theoretical Physics, Trieste. Italy.