Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and update vim syntax highlighting files #1501

Merged
merged 3 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@uihsnv
Copy link
Collaborator

commented Jun 8, 2019

Summary

  • Packaging instructions for vim syntax files
  • Put file-type-detect instructions in a file
  • Update list of known LAMMPS keywords

Related Issues

Closes #1500

Author(s)

Vishnu V. Krishnan (vishnugb -at- gmail.com)
Tata Institute of Fundamental Research, Hyderabad

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No issues.

Implementation Notes

I verified that both forms of using the syntax files: (a) in ~/.vim/ and (b) in the typical location for vim-files in linux, allows for syntax highlighting to work when using Vim.

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • A package specific README file has been included or updated
Simplify vim-files
Resolves #1500

@akohlmey akohlmey self-assigned this Jun 11, 2019

@akohlmey akohlmey changed the title Simplify vim-files Simplify and update vim syntax highlighting files Jun 11, 2019

@akohlmey akohlmey requested review from athomps, sjplimp and stanmoore1 Jun 11, 2019

@akohlmey akohlmey added this to the Stable Release Summer 2019 milestone Jun 11, 2019

@sjplimp
Copy link
Contributor

left a comment

fine by me

@akohlmey akohlmey merged commit bb0240d into lammps:master Jun 11, 2019

6 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details

@uihsnv uihsnv deleted the uihsnv:vim_files branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.