Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bond/react: angle constraints bugfix #1713

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@jrgissing
Copy link
Collaborator

jrgissing commented Oct 10, 2019

Summary

bugfix related to recent angle constraints option, on certain platforms

thanks to Keith Jones for noticing this

Related Issues

If this addresses an open GitHub issue for this project, please mention the issue number here, and describe the relation. Use the phrases fixes #221 or closes #135, when you want an issue to be automatically closed when the pull request is merged

Author(s)

JG

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Please state whether any changes in the pull request will break backward compatibility for inputs, and - if yes - explain what has been changed and why

Implementation Notes

Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in LAMMPS are affected

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

jrgissing added 2 commits Oct 10, 2019
rebase
@jrgissing jrgissing changed the title Bond/react angle constraints Bond/react: angle constraints bugfix Oct 10, 2019
@akohlmey akohlmey self-assigned this Oct 10, 2019
@akohlmey akohlmey requested review from athomps and sjplimp Oct 10, 2019
@akohlmey akohlmey merged commit 2b8f300 into lammps:master Oct 11, 2019
8 checks passed
8 checks passed
lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-kokkos-cuda-pr head run ended
Details
lammps/pull-requests/cmake/cmake-kokkos-omp-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
@jrgissing jrgissing deleted the jrgissing:bond/react-angle-constraints branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.