Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct warning issue in min_cg.cpp #1756

Merged
merged 1 commit into from Nov 4, 2019
Merged

Conversation

@julient31
Copy link
Collaborator

julient31 commented Nov 4, 2019

Summary

Correct a warning issue in min_cg.cpp.: the 'fmax' variable was used without being initialized.

Related Issues

None.

Author(s)

Julien Tranchida (jtranch@sandia.gov)

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Checked.

Implementation Notes

I checked the correction by re-running a set of serial and mpi minimization examples.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

- removed fmax uninitialized variable from min_cg.cpp
- removed tabs from comments
- initialized fdotf variables
@akohlmey akohlmey self-assigned this Nov 4, 2019
@akohlmey akohlmey requested review from sjplimp and athomps Nov 4, 2019
@athomps
athomps approved these changes Nov 4, 2019
@sjplimp
sjplimp approved these changes Nov 4, 2019
@akohlmey akohlmey merged commit cf251eb into lammps:master Nov 4, 2019
8 checks passed
8 checks passed
lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-kokkos-cuda-pr head run ended
Details
lammps/pull-requests/cmake/cmake-kokkos-omp-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.