Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #1789

Merged
merged 4 commits into from Nov 27, 2019
Merged

Patch 2 #1789

merged 4 commits into from Nov 27, 2019

Conversation

@evoyiatzis
Copy link
Collaborator

evoyiatzis commented Nov 26, 2019

Summary

Update of the manual for PyLammps

Related Issues

no related issues

Author(s)

Please state name and affiliation of the author or authors that should be credited with the changes in this pull request. If this pull request adds new files to the distribution, please also provide a suitable "long-lived" e-mail address (ideally something that can outlive your institution's e-mail, in case you change jobs) for the corresponding author, i.e. the person the LAMMPS developers can contact directly with questions and requests related to maintenance and support of this contributed code.

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Please state whether any changes in the pull request will break backward compatibility for inputs, and - if yes - explain what has been changed and why

Implementation Notes

Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in LAMMPS are affected

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

akohlmey and others added 4 commits Nov 21, 2019
… rst version
@evoyiatzis

This comment has been minimized.

Copy link
Collaborator Author

evoyiatzis commented Nov 27, 2019

@akohlmey sorry for messing up with this pull request. My intention was to add a short correction in the PyLammps documentation to your pull request. The proposed modifications are in 5 lines only. Please close it if it is more confusing than useful.

@rbberger rbberger assigned akohlmey and unassigned rbberger Nov 27, 2019
@rbberger rbberger requested a review from akohlmey Nov 27, 2019
@akohlmey akohlmey assigned rbberger and unassigned akohlmey Nov 27, 2019
@rbberger rbberger merged commit a5be6e5 into lammps:master Nov 27, 2019
7 checks passed
7 checks passed
lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/cmake/cmake-kokkos-omp-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
@evoyiatzis evoyiatzis deleted the evoyiatzis:patch-2 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.