Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in pair_granular.rst #1800

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

@jibril-b-coulibaly
Copy link
Collaborator

jibril-b-coulibaly commented Dec 6, 2019

Summary

The documentation states that tangent stiffness k_t equals 8G, instead of 4G/(2-\nu).
The calculation performed by PairGranular::mix_stiffnessG() is correct, this patch only corrects the typo in the documentation.

Related Issues

None

Author(s)

Jibril B. Coulibaly, Northwestern University

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No backward compatibility issue

Implementation Notes

The value of k_t = 4G/(2-\nu) is consistent with the literature (e.g. Radjaï and Dubois, 2011, ISBN: 978-1-848-21260-2), and with what the documentation of the pair style gran_hooke states.

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Correct formula for tangent stiffness, consistent with `PairGranular::mix_stiffnessG()`
@akohlmey akohlmey requested review from athomps and sjplimp Dec 17, 2019
@akohlmey akohlmey self-assigned this Dec 17, 2019
@sjplimp sjplimp requested review from dsbolin and removed request for athomps Dec 19, 2019
@akohlmey akohlmey merged commit 0dda120 into lammps:master Jan 6, 2020
6 checks passed
6 checks passed
lammps/pull-requests/cmake/cmake-kokkos-omp-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.