Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issues with CUDA-aware MPI #1803

Merged
merged 3 commits into from Dec 11, 2019
Merged

Conversation

@stanmoore1
Copy link
Contributor

stanmoore1 commented Dec 9, 2019

Summary

Fix a couple of issues with CUDA-aware MPI: don't change comm flags if there is only 1 MPI rank or if CUDA isn't enabled.

Author(s)

Stan Moore, reported by Christian Trott

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No issues.

@stanmoore1 stanmoore1 changed the title Fix issues with CUDA-aware MPI Fix performance issues with CUDA-aware MPI Dec 9, 2019
@stanmoore1 stanmoore1 self-assigned this Dec 9, 2019
@stanmoore1

This comment has been minimized.

Copy link
Contributor Author

stanmoore1 commented Dec 9, 2019

@stanmoore1 stanmoore1 requested a review from rbberger Dec 10, 2019
@stanmoore1 stanmoore1 assigned rbberger and unassigned stanmoore1 Dec 10, 2019
Copy link
Member

rbberger left a comment

@stanmoore1 if there is a change to an rst file, the corresponding txt file should also be deleted. I've just pushed this change.

@stanmoore1

This comment has been minimized.

Copy link
Contributor Author

stanmoore1 commented Dec 10, 2019

@rbberger good to know thanks

@rbberger rbberger merged commit 5e4e6b2 into lammps:master Dec 11, 2019
6 checks passed
6 checks passed
lammps/pull-requests/cmake/cmake-kokkos-omp-pr head run ended
Details
lammps/pull-requests/cmake/cmake-serial-pr head run ended
Details
lammps/pull-requests/kokkos-omp-pr head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.