Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to README and Makefile's in the GPU package #1807

Merged
merged 3 commits into from Dec 19, 2019

Conversation

@ndtrung81
Copy link
Contributor

ndtrung81 commented Dec 12, 2019

Summary

Update README and the Makefile's in lib/gpu with -L$(CUDA_HOME)/lib64/stubs so that libcuda.so in the recent versions of the CUDA toolkit can be found during linking

Author(s)

Trung Nguyen (Northwestern)

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

N/A

Implementation Notes

N/A

Post Submission Checklist

Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • A package specific README file has been included or updated
  • One or more example input decks are included
@ndtrung81 ndtrung81 requested a review from rbberger Dec 12, 2019
@rbberger rbberger self-assigned this Dec 12, 2019
@rbberger rbberger requested a review from akohlmey Dec 12, 2019
@rbberger rbberger assigned akohlmey and rbberger and unassigned rbberger and akohlmey Dec 12, 2019
@rbberger

This comment has been minimized.

Copy link
Member

rbberger commented Dec 12, 2019

The same issue happens with CMake. Not sure if we want to add something equivalent to the CMake build or just document the workaround by setting CMAKE_LIBRARY_PATH or CUDA_CUDA_LIBRARY directly. Comments?

@ndtrung81

This comment has been minimized.

Copy link
Contributor Author

ndtrung81 commented Dec 13, 2019

I would go with documenting the workaround by setting CUDA_CUDA_LIBRARY directly.

@rbberger rbberger assigned akohlmey and unassigned rbberger Dec 13, 2019
Copy link
Member

akohlmey left a comment

There is one incorrect use of the stubs path.

@@ -4,7 +4,7 @@ EXTRAMAKE = Makefile.lammps.standard
CUDA_ARCH = -arch=sm_35
CUDA_PRECISION = -D_SINGLE_DOUBLE
CUDA_INCLUDE = -I$(CUDA_HOME)/include
CUDA_LIB = -L$(CUDA_HOME)/lib64 -Xlinker -rpath -Xlinker $(CUDA_HOME)/lib64 -lcudart
CUDA_LIB = -L$(CUDA_HOME)/lib64 -Xlinker -rpath -Xlinker $(CUDA_HOME)/lib64/stubs -lcudart

This comment has been minimized.

Copy link
@akohlmey

akohlmey Dec 17, 2019

Member

This change is incorrect. You do not want to encode the CUDA stubs folder as rpath into an executable, you only want to use the stub folder for linking. At runtime you want the real libraries, not the stubs.

This comment has been minimized.

Copy link
@ndtrung81

ndtrung81 Dec 17, 2019

Author Contributor

You are right, sorry for the mistake.

@akohlmey akohlmey merged commit 8283e68 into lammps:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.