Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Find parallel NetCDF with cmake for USER-NETCDF #1819
USER-NETCDF module can be built with NetCDF or Parallel NetCDF library, or both. Depending on which one is available, different dump styles are compiled, namely "netcdf" for the former, "netcdf/mpiio" for the latter. So far, the new CMAKE build system fails to find and compile with Parallel NetCDF. An additional FindPNetCDF.cmake snippet in combination with some extensions within USER-NETCDF.cmake allow LAMMPS with USER-NETCDF to build both styles, depending on which library is available.
Johannes Hörmann, firstname.lastname@example.org, email@example.com
Please state name and affiliation of the author or authors that should be credited with the changes in this pull request. If this pull request adds new files to the distribution, please also provide a suitable "long-lived" e-mail address (ideally something that can outlive your institution's e-mail, in case you change jobs) for the corresponding author, i.e. the person the LAMMPS developers can contact directly with questions and requests related to maintenance and support of this contributed code.
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Note: The FindPNetCDF.cmake resides under GPL v3 at https://ftp.space.dtu.dk/pub/Ioana/pism0.6.1-10/CMake/FindPNetCDF.cmake and I am not sure whether this would conflict with LAMMPS GPL v2.
Correctness was tested with various custom test cases for netcdf dump styles at https://github.com/jotelha/lammps-testing/tree/master/tests/examples/USER/netcdf
Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in LAMMPS are affected
Post Submission Checklist
Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply
Further Information, Files, and Links
Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)