add dihedral multi/harmonic/kk#4482
Merged
Merged
Conversation
rbberger
force-pushed
the
dihedral_multi_harmonic_kokkos
branch
3 times, most recently
from
5127317 to
ba52f59
Compare
rbberger
force-pushed
the
dihedral_multi_harmonic_kokkos
branch
from
ba52f59 to
1f4b955
Compare
stanmoore1
approved these changes
Mar 28, 2025
Contributor
stanmoore1
left a comment
stanmoore1
left a comment
There was a problem hiding this comment.
Code looks good to me.
github-project-automation
Bot
moved this from Ready for Merge
to Done
in LAMMPS Pull Requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Kokkos version of multi/harmonic. Basically a copy of harmonic/kk with modified equations.
Related Issue(s)
Author(s)
@rbberger
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
Implementation Notes
Post Submission Checklist
Further Information, Files, and Links