New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 small bug fixes to load balancing #997

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@sjplimp
Copy link
Contributor

sjplimp commented Jul 11, 2018

Purpose

Two small bug fixes to load balancing. One for an uninitialized variable. The
other for turning off weight migration too soon before the final
imbalance factor was computed. Both could lead to valgrind issues
with unitialized memory being accessed or even a hang for the first one.

Thanks to Jon Bollinger (Sandia) for sending a test script to debug with.

Author(s)

Steve

Backward Compatibility

N/A

Implementation Notes

Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in LAMMPS are affected

Post Submission Checklist

Please check the fields below as they are completed

  • The feature or features in this pull request is complete
  • Suitable new documentation files and/or updates to the existing docs are included
  • One or more example input decks are included
  • The source code follows the LAMMPS formatting guidelines

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

Steven J. Plimpton

@sjplimp sjplimp merged commit 6dfb74f into master Jul 11, 2018

5 checks passed

lammps/pull-requests/build-docs-pr head run ended
Details
lammps/pull-requests/kokkos_omp head run ended
Details
lammps/pull-requests/openmpi-pr head run ended
Details
lammps/pull-requests/serial-pr head run ended
Details
lammps/pull-requests/shlib-pr head run ended
Details
@akohlmey

This comment has been minimized.

Copy link
Member

akohlmey commented Jul 11, 2018

@akohlmey akohlmey deleted the balance-bug-fix branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment